I had to do maintenance yesterday on a FreePBX17, I ran fwconsole ma upgradeall and then ran apt update, good I paid attention, and avoided the trixie install, not sure why the latest sysadmin wasn’t pushed to the stable repo, which would have avoided this.
Anyway, after this update, 100% of the extensions got FollowMe enabled. In addition to that, prior to this update, queue calls to extensions used to call the macro-dialout-one-predial-hook hook, but this changed to macro-dial-ringall-predial-hook. Obviously breaking integrations…
Finally, logging to the full log has stopped, I had to go to the GUI and change it from On to 3.
Did anyone else notice this? Was there any announcements about the last three points that I missed?
root@ADH-SP-PBX1:~# fwconsole setting MODULE_REPO
Setting of "MODULE_REPO" is (text)[https://mirror.freepbx.org]
Changing the predial hooks a queue uses is a pretty big change IMO.
There are the built-in hooks that people rely on, if an update simply stops any of these hooks from becoming relevant, then what is the point of allowing these hooks?
I am not mad, but I want you to understand how this customer looks at us.
They had a minor issue which required a PBX reboot, if we are already rebooting, then why not do maintenance?
We did.
Which resulted in:
ARI Broken, since it was changed from 0.0.0.0 to 127.0.0.1
FollowMe enabled on all extensions
Several custom features stopped working since the hook is looking hooking.
We weren’t able to right away diagnose these issues, since logging wasn’t working.
We got an email the following day that said something along the lines:
You started using AI? In the 7 years we have been with you guys we never had so many broken things and issues in one day. What happened?
Changing how the hooks work, are called or are named isn’t just something you can do without warning the user base that a major change like this is going to happen and could break integrations.
No one is asking Sangoma to test various custom integrations, we’re asking that making changes to how those integrations work should be announced a head of time.
This is going to keep biting people. Absolutely crazy and not like we didn’t say something before it went to stable. What’s the point of giving feedback here?
Anyone know the cause of this?
When is this going to be fixed @penguinpbx ? People have been complaining about it for months.
Here’s the changelog related to the https binding:
If I’m a thoughtful admin and read the change logs before updating modules that’s all I’ve got to work with, a single line saying “Adjusted for Local Access Only.” There’s no sense given here that this will break ARI or webrtc.
Other open source projects loudly proclaim breaking changes, often accompanied by a major version increment. This was a major change hiding after three decimal points in the version number. It’s possible that the misunderstanding here is that we disagree on what is a major change, but I assert that anything that changes the network configuration without asking is certainly a major change.
So yeah a “changelog top 10” would be great, with notice that the changes are going into edge on date X, proposed to go to stable on date Y, and with time for feedback. In this case I understand it was a security release, but the breaking change should still be noted even if it’s being rushed to stable.
