Vlan or Subnet for Voip.....softphones?

No, by putting QoS on a VLAN, you absolutely do not prioritize voice. You are instead prioritizing the entire VLAN. Broadcasts, DHCP, DNS, SIP, and yead RTP (the actual voice).

A VLAN is 100% never for voice QoS.