@ncorbic @mwhite @penguinpbx @kgupta
All, you need to sit down and figure out some proper testing and processes here. This entire Trixie/stable repo thing broken not only existing installs but now it is breaking new installs. It seems there is a lack of understanding on how these things are done.
If a version specific ISO/installer is used then that install is locked to that version’s repo. Cloud providers offer version specific and in some cases, stable based options. For example, when I installed Debian 12 last year on Vultr all my repos where already locked to:
deb http://deb.debian.org/debian bookworm main contrib non-free
By running the FreePBX v17 install script back then the install script locked me to:
deb http://deb.debian.org/debian stable main contrib non-free
So Sangoma made a choice to put people on the floating stable repo. It was a bad choice but it was made. Now when people are trying to install a Bookworm specific ISO/installer the FreePBX v17 installer script is doing this:
if [ ! "$noaac" ] ; then
add-apt-repository -y -S "deb $DEBIAN_MIRROR bookworm main non-free non-free-firmware" >> "$log"
fi
This of course causes it to not do what is expected since it’s already set to that repo and thus the result is this [Install Error]
The only time the stable repo is set is when a netinstall or using specifically a Stable ISO release. However, when using the netinstall release it asks you at the start of the install to select the track you want to use, the current version track or the stable track.
I don’t understand why this wasn’t tested in various scenarios and this “fix” was just rushed out. The real fix should have been validating if Bookworm was already being used or not.
This is what should be done in the install script.
if ! grep -RqsE 'deb\s+http://deb\.debian\.org/debian\s+bookworm\b' /etc/apt/sources.list /etc/apt/sources.list.d/; then
echo "deb http://deb.debian.org/debian bookworm main contrib non-free" | sudo tee /etc/apt/sources.list.d/bookworm.list
fi
I’ll add a PR in the hour or so once I finish this scheduled project task I’m about to start. But guys, these sloppy mistakes need to really be addressed and stopped. We keep questioning the QA/QC process, we’re told the processes are in place and then things like this keep happening over and over again.