How to perform a pull request?

FreePBX Development
1

I have an issue over on https://issues.freepbx.org that I’ve been instructed to make a pull request for. I’ve done this before for other projects on github, but I’m uncertain where to do it for this request. I’ve been going in circles and most of the docs/wikis are not current for development.

One I found here references here but is a 404.

I’m not sure if I need to be going to:
https://git.freepbx.org
https://jira.digium.com
https://code.sangoma.com
https://issues.sangoma.com


r/findanewjob

How does a pleb like me create a pull request for a perceived issue with FreePBX?

2

If it’s a specific module then that GitHub repo should be in there. If it’s the base system itself I’d guess that would be here --> https://github.com/FreePBX/core/pulls. Never done it myself, just an uneducated guess!

3

Sign in at git.freepbx.org, fork the module you want to work on, and then commit your changes and submit your PR.

4

How do you get an account at git.freepbx.org?

5

It’s the userman module.

Sorry, should’ve included a link to my issue.

6

All info here: https://wiki.freepbx.org/display/FOP/Developer+Corner+Home

As far as I recall, it’s just the same login as your forum account. I do not recall whether any additional permissions are needed.

1 Like
7

You will need to submit a CLA as well.

8

They are all modules. The base FreePBX system is the module called framework. The core module contains “core” functionality: extensions, trunks, outbound & inbound routes. Now you can make slightly more-educated guesses. :slight_smile: (Or bug fixes!)

1 Like
9

So the CLA is required before you can do a pull request?

10

Yes, required for PR to be merged.

1 Like
11

Are there different agreements for individuals vs corporate?

12

Once you have your CLA, go to git.freepbx.org and click fork.
image

That will make a copy under your account.
image

Click the 3 dots and choose create branch from here.
image

Choose bugfix, choose “release/15.0” in branch from.
Name it “FREEPBX-22572” or “FREEPBX-22572-add-tls-to-ldap” or something.
Click create.
image

Now edit the file or apply your patch to this branch and commit it. WHen you commit it make sure you have “Fixes FreePBX-22572” as part of the commit message.
image

Then click Create pull request
image

Select the proper branches. and hit continue (it is a matching color button and hard to see sometimes).

image
image837×407 27.1 KB

Add in a message (sorry no screenshot). and hit submit pull request.

1 Like
13

There is only one CLA, and it serves for both cases where you contribute the code personally or on behalf of your employer.

14

Thanks for the ELI5 version, I needed this!

15

I appreciate the clarification.

16

I try to be a bit thorough because I don’t know who will read anything in the future.

1 Like
17

This topic was automatically closed 31 days after the last reply. New replies are no longer allowed.