FreePBX outbound-CNAM module not compatible with freePBX 16

Charles_Darwin · February 20, 2022, 9:35am

Somebody else already mentioned it in another thread…just to confirm…
The Outbound-CNAM module does not work with freePBX 16. Screenshot below…
If you upgraded and already had a working setup, it seems still capable of injecting names into cdr but on my Ciscos it doesn’t show them during outgoing calls (which of course could be a consequence of me doing something wrong).
I don’t complain since this module is not part of the freePBX distro…but it was very useful

PitzKey · February 20, 2022, 2:01pm

Charles_Darwin · February 20, 2022, 2:52pm

Thanks…actually it partly works (cdr)…
I just posted it, in case somebody is using the module and wants to upgrade. The module wasnt supposed to work with freePBX 15 either, but it did…actually very well.

idho0618 · February 20, 2022, 9:19pm

Can you describe partly? A screen shot would be nice. I got it installed but received errors that are documented on that project. Maybe I missed a step that you got right. Thanks for your help.

Charles_Darwin · February 21, 2022, 6:52am

I meant that I already had the module set up in freePBX 15, so I didn’t have to use the web-gui of Outbound-CNAM. It populated the cdr correctly, but my Ciscos did not show the names.
Yet, it may be related to my weird upgrade style.
I had a freePBX 15 system with a patched Asterisk and ImageMagick installed. I had to fix several problems…e.g. I needed php-devel for the Installation for ImageMagick, but it wasnt available in the sng-repository. So I activated the remi-php74 repository. Then I found out that the freePBX php version was 7.4.16…the version in the remi-repo was 7.4.28. Then I updated the whole php to 7.4.28…next problem was that the LDAP-Superfecta lookup didn’t work with php-ldap 7.4.28.
So in the end I switched back to freePBX 15 (VirtualBox). Funny thing…when I started the old VM image, it said that freePBX is not activated. I had to activate it again, but no hardware reset was left…etc…

I really liked the new freePBX 16 with php 7.4. The response time of the web-gui seemed shorter. Yet, I will only upgrade machines which I havent touched.

franckdanard · February 21, 2022, 1:20pm

Hmm looks to have a syntax error for $module_local[module][version] which should be like this $module_local[“module”][“version”];
FreePBX 16 is using PHP7.4. Maybe this module needs to be migrated.
A review is necessary.

I did not read all the part of code. But it’s a clue.

lgaetz · February 21, 2022, 2:58pm

I did most of the work for this module, but I’m a bit rusty as I’ve not looked at the code literally in years. Can you share a link to a call trace of an outbound call, I see the dialplan splice is happening on my test system as expected.

Charles_Darwin · February 21, 2022, 6:08pm

Could you fix the problem with the web-gui already? Unfortunately I deleted my freePBX 16 VM image, currently I’m back on 15.
I might give it another try on the weekend…

thanks

jfinstrom · February 22, 2022, 2:53am

Put up a PR to bring this out of the stoneage…

lgaetz · February 22, 2022, 3:11pm

@jfinstrom’s changes have been merged and you can upgrade to 0.0.5 now. 0.0.5 supports FreePBX 15+ only. Thanks James

http://pbxossa.org/files/outcnam/

Charles_Darwin · February 26, 2022, 9:19am

Thanks a lot!!! I can confirm…just installed Outbound-CNAM on a new freePBX-16 distro and everything works
There is just one important step: Don’t install the Outbound-CNAM module on an unconfigured freePBX, it will crash the system. There has to be at least one outbound route configured, before you can install it.

jfinstrom · February 26, 2022, 3:27pm

Can you put a bug report on the GitHub page. I will fix that in the next few days.

Charles_Darwin · February 26, 2022, 11:04pm

Ok, I set up a new system and put a bug report on GitHub. It actually is not a big deal. To receive the error, you have to install the outbound-cnam module and activate it…without an outbound-route and without a trunk. I hope I did include all the information you need. Thanks

github.com/POSSA/freepbx-Outbound_CNAM

When installed on new freePBX-16 system and activated, the system cannot do a reload anymore

opened 11:00PM - 26 Feb 22 UTC

charles-darwin

The Outbound-CNAM module (if installed and activated) needs at least one outboun…d-route (and a trunk) in freePBX, otherwise the system cannot reload anymore. When you do a fwconsole reload you get this: [root@freepbx ~]# fwconsole reload --verbose Reload Started In extensions.class.php line 197: [Exception] died in splice macro-dialout-trunk s Exception trace: at /var/www/html/admin/libraries/extensions.class.php:197 extensions->splice() at /var/www/html/admin/modules/outcnam/Outcnam.class.php:111 FreePBX\modules\Outcnam->doDialplanHook() at /var/www/html/admin/libraries/BMO/DialplanHooks.class.php:107 FreePBX\DialplanHooks->processHooks() at /var/www/html/admin/libraries/Console/Reload.class.php:318 FreePBX\Console\Command\Reload->reload() at /var/www/html/admin/libraries/Console/Reload.class.php:91 FreePBX\Console\Command\Reload->execute() at /var/www/html/admin/libraries/Composer/vendor/symfony/console/Command/Command.php:255 Symfony\Component\Console\Command\Command->run() at /var/www/html/admin/libraries/Composer/vendor/symfony/console/Application.php:992 Symfony\Component\Console\Application->doRunCommand() at /var/www/html/admin/libraries/Composer/vendor/symfony/console/Application.php:255 Symfony\Component\Console\Application->doRun() at /var/www/html/admin/libraries/Composer/vendor/symfony/console/Application.php:148 Symfony\Component\Console\Application->run() at /var/lib/asterisk/bin/fwconsole:163 reload [--json] [--dry-run] [--skip-registry-checks] [--dont-reload-asterisk ![outbound-cnam](https://user-images.githubusercontent.com/8002658/155861621-14fd054d-f78e-4bb5-a431-8642e3d2d29e.png) ]

lgaetz · February 27, 2022, 6:56pm

I’ve committed a fix for the missing outroute/trunk issue. Can you test in production pls @Charles_Darwin:

github.com

lgaetz/freepbx-Outbound_CNAM/blob/master/Outcnam.class.php

<?php

namespace FreePBX\modules;

use BMO;
use PDO;
use Exception;

class Outcnam implements BMO
{
    public $FreePBX = null;

    public function __construct($freepbx = null)
    {
        if ($freepbx == null) {
            throw new Exception("Not given a FreePBX Object");
        }
        $this->FreePBX = $freepbx;
        $this->Database = $freepbx->Database;
    }

This file has been truncated. show original

Charles_Darwin · February 27, 2022, 9:09pm

On my new freePBX-16 test system, which showed the error when no outbound-route with a trunk was configured, I tested your new Outcnam.class.php. The reload problem disappeared.
I also replaced the code in the Outcnam.class.php of a production system, did a fwconsole reload and the Cisco 8961 and the CDR reports showed the outbound CNAM!
Wonderfull, thanks!!!

idho0618 · February 27, 2022, 10:23pm

All is working as expected on a fully patched PBXact system in production.

Thank you so much!

system · March 6, 2022, 10:23pm

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.