[quote][quote]
But until you do, anyone who uses that module doesn’t get a complete backup of their extension settings
[/quote]
Yes they do. It is in their backup when the use the Backup & Restore module.
[/quote]
Now hold on a minute here - that’s simply not true. The last “released module” in http://support.freepbx.org/trac/browser/contributed_modules/release was posted on 03/12/09 by p_lindheimer, and it included changes up through changeset 7497. You didn’t add permit/deny from Ticket #3584 until Changeset 7542 on 03/18/09 (almost a week later). And when you did that, you did not add C4colo’s changes separately, but you bundled them with some of your own localizations, thus making it impossible for me or anyone else to request Phillipe to publish Bulkextensions with C4colo’s changes alone, as I might otherwise have been able to do, given his comments on my Ticket #3719.
So I stand by my original comment - anyone who downloads version 2.5.0.4 from the release repository won’t get the benefit of C4colo’s patches, which means they won’t be able to backup and restore the permit/deny fields.
And just for future reference, how about in the future, when you add someone else’s patches you don’t bundle them with your own, so that those of us who may want those features to be made available earlier than whatever your release schedule might be can request that they be published? Note I’m saying that based on your previous assertion that you don’t “own” the module - therefore C4colo’s additions should have been placed in their own changeset.
[quote][quote]
I’m still not understanding how I “messed things up” by bumping the version.
[/quote]
OK, I will try to explain that s l o w l y…
[/quote]
…as you would to a complete moron. Got it.
[quote]When there is work in progress for a module (or core) it is in svn. When it is in svn there is absolutely no reason for bumping version numbers until the work is considered ready for release. When it is, a special tool is run against the work and you decide which revisions should go into the released version.
The tool build the module, updates the version number and place it is the released directory.[/quote]
And just where, pray tell, was THAT documented? I looked through the four links you sent me and nowhere that I could find does it say “don’t change the version number.” What was I supposed to do, get out my pointy hat with the stars on it and my crystal ball and intuit that this is how things are done? This is one of my big issues with the FreePBX development community in general - you have all these special procedures that you take for granted but when anyone else breaks an unwritten rule, you treat them like a complete idiot.
[quote]You can actually decide to not let a revision go into the module. So in this case with bulkextensions, when it is ready to be released I will notify Philippe that he can publish the module with revisions r7542, r7579, r7811. I do not want the revisions r7778, r7779, r7780 and r7781 go into the release.
[/quote]
And part of my point here is that C4colo’s changes which are included in r7542 should have been published three months ago when they were submitted, not sat upon until you got all of your other stuff done - again, assuming that others are allowed to work on this module other than you. You can’t have it both ways, either you claim ownership of the module or you don’t, but if you don’t you shouldn’t be standing in the way of changes made by others.
Well, again, please show me the page where that’s documented. I’m not saying you’re wrong, I’m just saying that if it isn’t documented then you have no business jumping all over someone as rudely as you jumped all over me. And, if it’s only documented in the middle of some obscure page that no one would ever look at unless they were deep into the development process, that shouldn’t count either.
[quote][quote]
I did some (very minor) work on Rob’s routepermissions module and bumped the version whenever I made an edit there, and nobody said a word about that,
[/quote]
Well, I did have a look at that, and I am sorry to say it wiseodlwol, that is not the correct way to do it.
If you go to http://support.freepbx.org/trac/log/contributed_modules/modules/routepermissions?rev=7812 and look at all the changes that Rob have done you will find that he never touches module.xml to change the version number.
[/quote]
And yet at the time nobody said a single word to me that it was wrong. And if you look at module.xml in the released version, all my version changes are still there, so obviously Phillipe had no problem with me changing the version, otherwise I’m sure he would have reverted the changes and/or said something to me. It’s YOU who are being such a hardcase (believe me, there are other words I could have used there) about this.
[quote][quote]
they can get a newer version WITH C4colo’s patches and some additional things you’ve added, but even then it will still be version 2.5.0.4.
[/quote]
No, they cant, what they can get (if they download it from svn) is a beta not ready for release. Remember, in svn it is work in progress.
You can use this code to get the latest changes down to FreePBX, I do as I have a couple of machines in vmware where I test all things before committing it back to svn.[/quote]
Okay, fine, it’s a beta. As for “not ready to release”, I will just point out that C4colo’s changed version (the one you took it upon yourself to delete from his ticket) WAS ready to release. Maybe not through the “official” third party repository, but it was definitely ready for use.
Gee, I wonder why some third-party developers are choosing to eschew the official third-party repository and simply put their FreePBX modules up on their own sites?
[quote][quote]
why are you the only one allowed to determine when and under what circumstances the version number should be bumped?
[/quote]
I am not, it is the publish tool that does that.
[/quote]
Okay, and just for the record, I will say that in my opinion that’s the wrong way to do things. If you look at most other projects, even unreleased versions get their own version numbers. If FreePBX wants to stand pretty much alone in the software world as only doling out new version numbers to “release” versions (as if version numbers were some sort of scarce resource) then there’s nothing I can do to change that, but I will at least have the courage to tell you that I think you or anyone else who thinks it’s a good idea to reserve version numbers for releases only is just wrong. And it especially causes problems for those who may get a version of the software using SVN, because it makes it more difficult to know which particular version anyone may have - you can’t just look at the version number on the module.
So stone me for saying it if you like, but this just isn’t the right way to do things.
[quote][quote]
I just think these things should be clarified. If I don’t understand how the process works, I’m willing to bet there are others who don’t either
[/quote]
Guidelines for svn are here http://freepbx.org/trac/wiki/Guidlelines
How to pull the latest development code http://freepbx.org/trac/wiki/SvnPull
Working with SVN http://freepbx.org/trac/wiki/SvnTips
Preparing a Release Tarball: http://freepbx.org/trac/wiki/FreePbxRelease
[/quote]
Thank you for those references. As I noted above, I could not find anywhere that it said not to bump the version number. Of course, it would be nice if there were links to this sort of documentation in some document.
I think FreePBX could really benefit from a document entitled something like, “So you want to write a FreePBX module - here are the essentials you need to know” (okay, so the title could be shortened, but you get my drift). The problem is that the developers (well, SOME developers) seem to take for granted that others know everything about the development process that they do, when nothing could be further from the truth. And every time I think I have some part of it figured out, it turns out I’m completely wrong.
[quote][quote]
if you remember the morning that I made my mistake, you were pretty condescending to me at the time
[/quote]
Well, I was, because if you notice the changes that you did removed a lot of my work that I have done for localization, r7778
If you look at all the text with red background, all that was removed when you committed the code back to svn.
All text with green background is what you added. So, yes I was upset, I reverted those changes and let some steam out on irc.
[/quote]
Right. And it never even occurred to you that I was just trying to be helpful and to clear a ticket out of the ticket system, something that I had THOUGHT (up until that point) that the developers wanted some help with. I had NO intention of stepping on your toes, but that didn’t stop you from acting like I was either being malicious or stupid. Okay, maybe I WAS ignorant of the process, but you could have pointed that out in a different manner.
Yes, and I admit I should have done that, but again it never occurred to me because I was just going by the version number. You make mistakes, you live and learn, and you hope that no one bites your head off in the process. But I get the feeling that you are sort of a control freak (in part because you are so uptight about spelling errors) and you just can’t let anyone else live and learn, you have to lay down the law as if they were your subordinate - or your child. You just happened to pick the wrong person to vent on when you started in on me.
You know what, this whole situation (and the “f off and die” comment in the IRC channel yesterday, which I know wasn’t by you but still was uncalled for) has left a bad taste in my mouth for the IRC channel right now. I need a few days to cool down - if I were to talk to you in IRC right now I just don’t think it would be a very productive discussion.
I just want to say that you guys may not see it but you do sometimes treat would-be developers (and others who may wish to participate in some way) like crap when they don’t know everything you know. I see that sometimes it goes both ways (thinking of one guy in particular) but you really don’t give the potential developer much to go on. In particular there is a real lack of accessible, clear documentation that explains the whole process. And by “accessible” I mean that it’s where anyone can find it, not just those who may have a particular page bookmarked. I know there are things I am ignorant about and that I make mistakes, but to put it in perspective, suppose you were offered a chance to play a game, but part of the game was that you had to discover the rules of the game as you went along, and if you break a rule they shoot you! Not may people would choose to participate under those circumstances. I know I certainly won’t be very inclined to try to help out in any way after this.