As ever, experimenting with improving superfecta and the module framework, I did two tests:
First, I ran the superfecta.agi script in isolation, fed it the correct data, and got the expected result.
Then, I added:
$bootstrap_settings['include_framework_functions'] = false;
to see what the speed up was.
However, I then got a crash:
PHP Warning: set_error_handler() expects the argument (freepbx_error_handler) to be a valid callback in /var/www/html/admin/bootstrap.php on line 117
PHP Fatal error: Class 'FreePBX\Freepbx_conf' not found in /var/www/html/admin/libraries/BMO/FreePBX.class.php on line 16
Whoops\Exception\ErrorException: Class 'FreePBX\Freepbx_conf' not found in file /var/www/html/admin/libraries/BMO/FreePBX.class.php on line 16
Stack trace:
1. () /var/www/html/admin/libraries/BMO/FreePBX.class.php:16
Delving into this, line 16 of …/libraries/BMO/FreePBX.class.php is:
class Freepbx_conf extends FreePBX\Freepbx_conf {};
This suggest to me that BMO.interface.php should include ‘Freepbx_conf.class.php’. However, given the warnings in that file about not adding spurious includes, I wanted to ask here.
Should BMO.interface.php file have
include "Freepbx_conf.class.php';
somewhere in the top include section? To me this would make sense so that BMO stands independent, but I may be wrong!