Unable to reload after removing key in VoIPInnovations module

[lncjohn (John M)]

In the VoIPInnovations configuration module, if you add an account key, apply the configuration, remove the the key, then attempt to apply the changes again, the reload will crash with the following:

fwconsole reload --verbose
Reload Started

In extensions.class.php line 197:

[Exception]
died in splice macro-dialout-trunk s

Exception trace:
at /var/www/html/admin/libraries/extensions.class.php:197
extensions->splice() at /var/www/html/admin/modules/allowlist/functions.inc.php:212
allowlist_hookGet_config() at /var/www/html/admin/libraries/BMO/DialplanHooks.class.php:95
FreePBX\DialplanHooks->processHooks() at /var/www/html/admin/libraries/Console/Reload.class.php:318
FreePBX\Console\Command\Reload->reload() at /var/www/html/admin/libraries/Console/Reload.class.php:91
FreePBX\Console\Command\Reload->execute() at /var/www/html/admin/libraries/Composer/vendor/symfony/console/Command/Command.php:255
Symfony\Component\Console\Command\Command->run() at /var/www/html/admin/libraries/Composer/vendor/symfony/console/Application.php:992
Symfony\Component\Console\Application->doRunCommand() at /var/www/html/admin/libraries/Composer/vendor/symfony/console/Application.php:255
Symfony\Component\Console\Application->doRun() at /var/www/html/admin/libraries/Composer/vendor/symfony/console/Application.php:148
Symfony\Component\Console\Application->run() at /var/lib/asterisk/bin/fwconsole:163

reload [–json] [–dry-run] [–skip-registry-checks] [–dont-reload-asterisk]

Re-adding the account key in the VoIPInnovations module allows the reload to succeed.

Steps to reproduce:

1. create a VoIPInnovations Sangoma PBX endpoint
2. copy endpoint config key into VoipInnovations FreePBX module and “aAdd Key”
3. Apply the configuration.
   (note: at this point in my configuration, the registration status for each of the VI servers is “rejected” in my VI module. Clicking "Refresh Asterisk Account Info returns “An error occurred while contacting servers for account information”. This may or may not be relevant.)
4. In the VI module, under “Location Information” click “Remove Key”
5. Click “Apply”. FreePBX returns "Unknown Error. Please Run: fwconsole reload --verbose "
6. Run “fwconsole reload --verbose” on the console. The console returns the above error.

FreePBX 16.0.19
VoIPInnovations module 16.0.16
Disto 12.7.8-2204-1.sng7

[lgaetz (Lorne Gaetz)]

this is not related to the vi module, it’s an issue with an allowlist that will fail if there are no outbound routes (or maybe trunks) defined. There is a fix, not sure if it’s been published yet.

[lncjohn (John M)]

Got it. So just make sure there is at least one trunk and/or outbound route. Thank you!