Suggestions for future versions of FreePBX


#17

Hi Lorne, and thanks for taking to the time to address some of my comments.

I don’t have any problem with any of what you had said. But, moving to the new doesn’t necessarily mean eliminating the old.

Well, that confusion is entirely of your own making. I’ve said it before, and I’ll say it again: You need better documentation.

That is all perfectly reasonable, but none is a reason disable chan_sip by default in new installations.

Any technical debt today is the same as the technical debt five years ago.

Well, that’s just silly. As long as chan_sip works, and it’s included in FreePBX and Asterisk, people should be allowed to recommend its use.


(Tom Ray) #18

Alright, I may have lumped it in with the app_macro for FreePBX as the reason.


#19

And that is the same reason that I believe that chan_sip should remain enabled by default in new builds of the FreePBX distro, or that, at least, the user should be given some kind of notice during the installation of FreePBX so that they can make an informed choice.

I recognize that the new user will be able to enable it in the advanced settings module. And you guys will be fielding a ton of such inquiries here in the forums and giving that very same recommendation. :slight_smile:


(Tom Ray) #20

What is being referred to in the amount of deployments with chan_sip still in use. A new user that has never installed FreePBX should not be starting with chan_sip so they can be told to move away from it within the next 2 years. When the goal is to get existing users to migrate the best plan is to not keep adding new users to that list. You stop new deployments from using the thing you’re trying to remove and work on getting the existing people to migrate.

Your suggestion of keeping chan_sip active for people to select as their primary SIP driver is actually adding to the problem of getting people to migrate off of chan_sip.


(Simon Telephonics) #21

Your recommendations for chan_sip come with vague claims of pjsip bugs, “not ready”, and etc. Yet when pressed to show the bug reports, there aren’t any. A chan_sip recommendation would hold a lot more weight if you actually showed the open bug ticket(s) supporting your reasoning for using the deprecated driver.

Please link tickets. And then when the bugs are fixed, future readers can see that the recommendation was made while there was a bug but that it was resolved and is no longer an issue.


#22

Is that all that I needed to do? Here you go:

https://issues.asterisk.org/jira/browse/ASTERISK-28793?jql=text%20~%20"pjsip"

I only post recommendations that people try chan_sip when people post a comment stating that they’re having trouble with pjsip. Using chan_sip when you have trouble with pjsip is always a good trouble-shooting step.

There’s a post on the forums right now about a pjsip bug relating to NAT. And it is a bug that I’ve seen myself. Here’s one:

Thanks for giving me this chance to convert you. I assume that you’re in my camp now that I’ve given you precisely what you asked for! :slight_smile:


(Sam Shomi) #23

This post was flagged by the community and is temporarily hidden.


(Matt Brooks) #24

Unfortunately, I don’t think this will ever be possible due to mostly security concerns. Instead may I ask what part of Sysadmin should be open source?


(Simon Telephonics) #25

If I were experiencing show-stopping bugs with pjsip, yes, I’d use chan_sip. But I haven’t used it on an installation in 2 years or so now. I acknowledge that some people might have situations where they are encountering bugs, and chan_sip might work better for them.

To be clear about my request – and I think you know what I meant – I was saying that if someone is writing here about a configuration issue and you are recommending chan_sip to them, it ought to come with a specific bug report about pjsip, not just a search for pjsip on the asterisk bug tracker.

(A similar search for “chan_sip” in the bug tracker also produces a large list of open bug reports.)


(Sam Shomi) #26

All of it. We all know it is obfuscated for mostly business reasons. There is no argument for security through obscurity imo.


#27

Even ignoring my suggestions, chan_sip will still be available for people to select as their primary SIP driver. All that they’ll need to do is go into the advanced settings module and enable it.

And that ties in nicely with my suggestion about educating new users during the install and allowing them to make a choice.


(Tom Ray) #28

Can you show tickets that don’t A) have the author admit it is a one time and hasn’t been reproduced and B) are against an active and supported version of Asterisk. v13 was moved to Security Fixes Only last year, it fully goes EOL in 2 weeks. This ticket was against 13.32.0 which was early 2020, 13 had a few more updates before going SFO and has had SFO updates. v13 is currently at 13.38.3

So current releases of Asterisk and actual, reproducible bugs that actually impact people. Those are qualifiers.


(Matt Brooks) #29

I would say Sysadmin is the anti-opensource module if there ever was one to be honest. There are much better ways to manage a system than using Sysadmin. Using the sysadmin module prevents FreePBX from also working with automation tools such as ansible. If anything I’m more surprised you all aren’t fighting for LESS to be done in Sysadmin, or better compatibility with the way linux machines are typically managed.


#30

Ideally, the whole thing.

System Admin was non-commercial module for the first version of FreePBX that it was released in.


(Sam Shomi) #31

If you are saying that sysadmin should be scraped completely then we are on the same page, as long as whatever replaces, if anything, is open source.

Start by untying the firewall module from sysadmin and/or getting rid of that as well. Both the firewall module and the sysadmin modules are perfect examples of how not to put a GUI on linux.

There are much better ways to do it where it does not get in the way of how linux naturally does it. VirtualMin/Webmin is a perfect example of a project that does not get in the way of Linux. You are still able to do the same things on the command line and the two never fight with each other. Pretty much the exact opposite of the sysadmin and firewall modules.


#32

That’s a totally valid point. I don’t use System Admin at all.

Again, my comments are directed towards ensuring that the project is accessible to new users, and that they can get a system up a running without a large learning curve. Once they have to learn parts of CentOS, all bets are off and they might just head over to 3CX. System Admin is good part of that.

I agree 100%.


#33

Again, I’m not telling anyone NOT to use pjsip. If it works for your situation, that’s great. But, lots of people are reporting that it doesn’t work for their situation. The usual response seems to be to forward all your ports, which is terrible security advice, and is generally not necessary.

Reports of pjsip issues are all over the forum. If you can’t accept these, then I don’t know what to tell you. Again, here’s one from a few days ago, that I experienced MYSELF as well:


(TheJames) #34

dead-horse-spank
chan_sip is dead. Move or don’t update once it is gone completely. This really is not a debate.


(Tom Ray) #35

Let us not conflate FreePBX issue with chan_pjsip with actual Asterisk chan_pjsip issues. They can be totally different things.

FreePBX writing out Dialplan or configs that are incorrect is not the same as a chan_pjsip bug.


#36

You are the first person to bring that up, and I agree that we should not conflate things that have nothing to do with our current discussion.