Asterisk Version Checks...are some of them really needed now?

FreePBX Development
1

Do we really need to, in 2025, check for versions of Asterisk that are a decade old in the code logic for current versions of FreePBX?

if (version_compare($this->version,'1.6','ge')) 

if (version_compare($this->version,'1.8','ge'))

if (version_compare($this->version,'11','ge'))

This one has variations of checking for versions **lower** than 12 or 13 to output blocks of code.
if(version_compare($version, '12', 'lt'))

The checks that are looking for versions greater than 1.6, 1.8, etc are always going to pass because those versions are no longer used and the versions used are always going to be greater than those versions.

The same logic applies for checking for lower than versions that are no longer used. Those checks will always fail meaning that code is just a waste of space. At some point all this junk code needs to be removed but it just looks like the SOP is to just stack new stuff on top of the junk.

Look at the code is like watching Hoarders, a bunch of junk that is no longer needed but no one can get rid of it.

2

https://github.com/FreePBX/framework/pulls

3

What am I supposed to be looking at?

4

There’s no immediate profit to be had in cleaning up old code so don’t expect Sangoma to do it. You can file a PR to fix deficiencies you see in the code (though they aren’t even handling those very quickly these days.)